Skip to content

fix: align Bazaar body-discovery remediation copy#80

Merged
fardinvahdat merged 2 commits into
fardinvahdat:mainfrom
TateLyman:codex/bazaar-body-fix-copy
May 24, 2026
Merged

fix: align Bazaar body-discovery remediation copy#80
fardinvahdat merged 2 commits into
fardinvahdat:mainfrom
TateLyman:codex/bazaar-body-fix-copy

Conversation

@TateLyman
Copy link
Copy Markdown
Contributor

Summary

  • keep the well-known failure remediation variant-aware for body-discovery Bazaar metadata
  • avoid telling body-discovery services to add MCP-style name/description fields when the failing fields are info.input/output/schema
  • widen the internal read helper return type to match both supported extension variants

Verification

  • pnpm vitest run tests/unit/bazaar-well-known.test.ts tests/unit/bazaar-challenge.test.ts tests/unit/bazaar-extensions-bazaar.test.ts
  • pnpm typecheck
  • pnpm prettier --check "src/bazaar/{well-known,challenge}.ts" tests/unit/bazaar-well-known.test.ts
  • git diff --check

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@TateLyman is attempting to deploy a commit to the fardinvahdat's projects Team on Vercel.

A member of the Team first needs to authorize it.

@TateLyman TateLyman force-pushed the codex/bazaar-body-fix-copy branch from 58b32f5 to f1d9250 Compare May 22, 2026 22:34
fardinvahdat added a commit that referenced this pull request May 22, 2026
Seven D.x + infrastructure tickets through the strict 6-stage audit
gate: X402-41 (ADR-004) + X402-42 (D.4 --endpoint per-route probe) +
X402-43 (D.5 variant-aware extensions.bazaar) + X402-44 (JSON API
stability + snapshot test) + X402-45 (D.2 propagation diff) + X402-46
(D.3 indexer-state + upstream_stuck verdict) + X402-47 (fixture-
consumption infrastructure). Plus X402-40 (Node 22 npx hang README
workaround, Solana-dep drop branch shelved per 2-voice convergence).

511 tests (was 429 at v0.3.1, +82). 102 files / ~407 KB unpacked
(was 96 / ~349 KB at v0.3.1). 0 devDep imports from dist/. Runtime
deps unchanged (commander + dotenv + viem + x402). No breaking
changes — JSON API additions are strictly additive per the new
ADR-004 Pillar 2 versioning rule.

Bumps:
  package.json: 0.3.1 → 0.3.2 + description rewrite (surfaces D.2/D.3/
    D.4/D.5 + JSON API contract for npm search)
  src/cli/index.ts: VERSION 0.3.1 → 0.3.2
  scripts/check-publish-surface.mjs: MAX_UNPACKED_BYTES 400 KB → 420 KB
    (six new dist/ modules + fatter CHANGELOG; reverts in v0.3.3)
  README.md: Roadmap (v0.3.2 current), Install (X402-40 Node 22 +
    npx hang workaround), FAQ (supply-chain answer v0.3.1 → v0.3.2),
    Acknowledgments (+6 v0.3.2 contributors)
  CHANGELOG.md: [0.3.2] section with full Notes + Contributors blocks,
    link footer
  CLAUDE.md: Status line — v0.3.2 release-cut in progress

Contributors credited: @AsaiShota, @evanatpizzarobot, @0xdespot,
@TomSmart_ai, @Cryptor + @ferj (cdp-only correction → ADR-004
Pillar 3), @zev (D.2 origin pattern), Max (D.3 origin pattern),
@hypeprinter007-stack (PR #70 + cycle work), @peterxing (v0.3.1
fold-forward), @TateLyman (pending #80; defer to v0.3.2.1 if not
merged before squash).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@fardinvahdat
Copy link
Copy Markdown
Owner

fardinvahdat commented May 22, 2026

Hi @TateLyman — welcome, and thank you for the contribution.

Audit ✅ — the copy fix is correct and the diff is appropriately scoped.

The PR stayed open through the v0.3.2 ship window because the release branch had already been cut and the audit log threading takes a separate pass for contributor PRs. v0.3.2 just shipped to npm (x402trace@0.3.2, provenance + signed attestations); your PR is the first item on the v0.3.2.1 fast-follow list along with the @tomsmart cdp-mature fixture (dropping in #show-and-tell on Sunday 2026-05-24).

Expected v0.3.2.1 cut: 2026-05-26 ± a day depending on the fixture wire-up complexity. You'll be credited in the CHANGELOG ### Fixed section for v0.3.2.1.

If you have time to engage further, the contributor handbook at CONTRIBUTING.md has the JSON API discipline section that v0.3.2 just added — every JSON-envelope change now needs a snapshot update + CHANGELOG line. Not blocking for this PR (copy fix doesn't touch the envelope), just context for future contributions.

Thanks again — the body-discovery remediation copy was the only stale corner of the human-format output. Fix is clean.

@TateLyman
Copy link
Copy Markdown
Contributor Author

Thanks for the fast review and the credit. I’ll keep the no-payment checks scoped to the JSON envelope / body-discovery path, and I’ll re-run against v0.3.2.1 when it ships.

If you want, I can also turn this into a compact launch-readiness note for the contributor handbook so future fixture updates keep the same contract shape. No paid calls or payment headers used.

@fardinvahdat
Copy link
Copy Markdown
Owner

fardinvahdat commented May 23, 2026

Yes please @TateLyman — that handbook contribution is exactly the kind of follow-up that makes the first contribution lead to the second. Scoping suggestion to keep the change focused:

Where it should live: CONTRIBUTING.md (extending the existing "JSON API discipline" section that v0.3.2's X402-44 just added) rather than a new file. Keeps the contributor surface single-source.

What should be in scope:

  • The fixture-update contract shape (e.g., when a contributor adds a captured-response fixture, what schema fields are required, where the schema is locked, how the test harness consumes it)
  • The body-discovery vs MCP-discovery decision tree from a contributor's lens (you've now touched the body-discovery remediation copy, so you've seen the actual user-facing impact of getting the variant wrong)
  • A "no-payment-required test discipline" subsection — your "no paid calls or payment headers used" note from this PR's body is the exact framing that should be normalised for future contributors

What's out of scope (for this contribution — easy to expand later):

  • Architectural decision records (those go in DECISIONS.md and need maintainer signoff)
  • Anything that requires running paid calls in CI (the cost-discipline rule needs a separate ADR)

On v0.3.2.1: I'll branch the release work today and bundle your copy-fix into the cut. Expected ship: 2026-05-26 ± 1 day. The handbook contribution can go in the same release if you have time, or land separately as a follow-up — your call. Either way, you're in the v0.3.2.1 CHANGELOG ### Fixed for this PR, and the handbook contribution would get its own ### Documentation entry.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
x402trace-dogfood Ready Ready Preview, Comment May 24, 2026 4:51pm

@fardinvahdat fardinvahdat merged commit 461a3cd into fardinvahdat:main May 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants